From 43d8a84a92af629c81b9093c4c2b5394d1b78a4d Mon Sep 17 00:00:00 2001
From: Eric Hameleers <alien@slackware.com>
Date: Fri, 22 Dec 2017 00:35:53 +0100
Subject: kde/applications/kate: allow to be started by the root user

This reverts a patronizing commit by a KDE developer.
Please leave these kinds of decisions to the end-user!
---
 kde/patch/kate.patch                |  4 ++++
 kde/patch/kate/kate_runasroot.patch | 48 +++++++++++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 kde/patch/kate/kate_runasroot.patch

diff --git a/kde/patch/kate.patch b/kde/patch/kate.patch
index d8cd42f..45c2f53 100644
--- a/kde/patch/kate.patch
+++ b/kde/patch/kate.patch
@@ -2,3 +2,7 @@
 # Should be fixed after 15.12.0.
 #cat $CWD/patch/kate/kate-15.12.0.patch | patch -p1 --verbose || { touch ${SLACK_KDE_BUILD_DIR}/${PKGNAME}.failed ; continue ; }
 
+# Allow Kate to be started by the root user; disallowing this is not
+# a decision that a developer should make for the user, it is patronizing:
+cat $CWD/patch/kate/kate_runasroot.patch | patch -p1 --verbose || { touch ${SLACK_KDE_BUILD_DIR}/${PKGNAME}.failed ; continue ; }
+
diff --git a/kde/patch/kate/kate_runasroot.patch b/kde/patch/kate/kate_runasroot.patch
new file mode 100644
index 0000000..88dbbe9
--- /dev/null
+++ b/kde/patch/kate/kate_runasroot.patch
@@ -0,0 +1,48 @@
+From 435ed5853b9451ab8fdfff722545c57a8f154625 Mon Sep 17 00:00:00 2001
+From: Fabian Vogt <fabian@ritter-vogt.de>
+Date: Sat, 18 Feb 2017 13:49:14 +0100
+Subject: [PATCH] Defuse root block
+
+While the main point is correct as any application running in the same
+X session (not sandboxed) can use kate's capability to open a console,
+we allow (even encourage) running YaST on X11 as root.
+That way it's only an impact on usability.
+---
+ kate/main.cpp   | 3 +--
+ kwrite/main.cpp | 3 +--
+ 2 files changed, 2 insertions(+), 4 deletions(-)
+
+diff --git a/kate/main.cpp b/kate/main.cpp
+index 342cd5db3..4845646aa 100644
+--- a/kate/main.cpp
++++ b/kate/main.cpp
+@@ -64,9 +64,8 @@ int main(int argc, char **argv)
+      * Check whether we are running as root
+      **/
+     if (getuid() == 0) {
+-        std::cout << "Executing Kate as root is not possible. To edit files as root use:" << std::endl;
++        std::cout << "THIS IS POTENTIALLY INSECURE!\nTo edit files as root please use:" << std::endl;
+         std::cout << "SUDO_EDITOR=kate sudoedit <file>" << std::endl;
+-        return 0;
+     }
+ #endif
+     /**
+diff --git a/kwrite/main.cpp b/kwrite/main.cpp
+index 68a055edb..4937f72d3 100644
+--- a/kwrite/main.cpp
++++ b/kwrite/main.cpp
+@@ -54,9 +54,8 @@ extern "C" Q_DECL_EXPORT int main(int argc, char **argv)
+      * Check whether we are running as root
+      **/
+     if (getuid() == 0) {
+-        std::cout << "Executing KWrite as root is not possible. To edit files as root use:" << std::endl;
++        std::cout << "THIS IS POTENTIALLY INSECURE!\nTo edit files as root please use:" << std::endl;
+         std::cout << "SUDO_EDITOR=kwrite sudoedit <file>" << std::endl;
+-        return 0;
+     }
+ #endif
+     /**
+-- 
+2.12.2
+
+
-- 
cgit v1.2.3