From b0137f694f946c7f10ac2863a71b4cdeda15eb87 Mon Sep 17 00:00:00 2001 From: Wolfgang Bauer Date: Wed, 14 Sep 2016 23:54:40 +0200 Subject: [PATCH 2/3] Add some missing(?) link libraries This fixes the following build errors in openSUSE Factory: CMakeFiles/python_module_PyKDE4_dnssd.dir/sip/dnssd/sipdnssdpart2.cpp.o: In function `meth_DNSSD_ServiceBrowser_resolveHostName': /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/dnssd/sipdnssdpart2.cpp:408: undefined reference to `QHostAddress::QHostAddress(QHostAddress const&)' /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/dnssd/sipdnssdpart2.cpp:408: undefined reference to `QHostAddress::~QHostAddress()' collect2: error: ld returned 1 exit status ... CMakeFiles/python_module_PyKDE4_kio.dir/sip/kio/sipkiopart3.cpp.o: In function `meth_KFilePlacesModel_deviceForIndex': /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart3.cpp:18560: undefined reference to `Solid::Device::Device(Solid::Device const&)' /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart3.cpp:18560: undefined reference to `Solid::Device::~Device()' CMakeFiles/python_module_PyKDE4_kio.dir/sip/kio/sipkiopart4.cpp.o: In function `meth_KDeviceListModel_deviceForIndex': /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart4.cpp:27090: undefined reference to `Solid::Device::Device(Solid::Device const&)' /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart4.cpp:27090: undefined reference to `Solid::Device::~Device()' collect2: error: ld returned 1 exit status REVIEW: 127705 --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b0768cf..b919d1b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -166,7 +166,7 @@ add_sip_python_module(PyKDE4.kdeui sip/kdeui/kdeuimod.sip ${KDE4_KDEUI_LIBS} ${Q file(GLOB kio_files_sip sip/kio/*.sip) set(SIP_EXTRA_FILES_DEPEND ${kio_files_sip}) -add_sip_python_module(PyKDE4.kio sip/kio/kiomod.sip ${KDE4_KIO_LIBS} ${KDE4_KFILE_LIBS}) +add_sip_python_module(PyKDE4.kio sip/kio/kiomod.sip ${KDE4_KIO_LIBS} ${KDE4_KFILE_LIBS} ${KDE4_SOLID_LIBS}) file(GLOB kutils_files_sip sip/kutils/*.sip) set(SIP_EXTRA_FILES_DEPEND ${kutils_files_sip}) @@ -190,7 +190,7 @@ add_sip_python_module(PyKDE4.knewstuff sip/knewstuff/knewstuffmod.sip ${KDE4_KNE file(GLOB dnssd_files_sip sip/dnssd/*.sip) set(SIP_EXTRA_FILES_DEPEND ${dnssd_files_sip}) -add_sip_python_module(PyKDE4.dnssd sip/dnssd/dnssdmod.sip ${KDE4_KDNSSD_LIBS} ${QT_QTCORE_LIBRARY}) +add_sip_python_module(PyKDE4.dnssd sip/dnssd/dnssdmod.sip ${KDE4_KDNSSD_LIBS} ${QT_QTCORE_LIBRARY} ${QT_QTNETWORK_LIBRARY}) file(GLOB phonon_files_sip sip/phonon/*.sip) set(SIP_EXTRA_FILES_DEPEND ${phonon_files_sip}) -- 2.9.3