summaryrefslogtreecommitdiffstats
path: root/kde/patch/kscreenlocker/kscreenlocker_CVE-2016-2312.patch
blob: 492ef802d31385575c4803ee9e0bebaf321472a5 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
From: Martin Gräßlin <mgraesslin@kde.org>
Date: Fri, 05 Feb 2016 09:30:19 +0000
Subject: [greeter] Dont quit when last window closes
X-Git-Url: http://quickgit.kde.org/?p=kscreenlocker.git&a=commitdiff&h=fae65f1cdd6446042b31ccd0eafd7a4c0b6623e3
---
[greeter] Dont quit when last window closes

Qt allows to have no screens. If all XRandR screens are disconnected
there are also no QScreens. This is from an X11 perspective wrong, but
we have to deal with it. No QScreens means that all views are destroyed
and no new ones are created. Thus all windows close and the greeter
exited successfully which in turn unlocked the screen.

This change ensures that the greeter doesn't exit when all windows close.

Funnily this was not a problem with the well known issue of Qt
crashing when all screens are disconnected. The lock screen handles
crashes gracefully and just restarts or more likely Qt also crashes
the application using KSld and thus taking down the complete session.

BUG: 358125
FIXED-IN: 5.5.5
---


--- a/greeter/main.cpp
+++ b/greeter/main.cpp
@@ -59,6 +59,7 @@
         qputenv("QT_IM_MODULE", QByteArrayLiteral("compose"));
     }
     ScreenLocker::UnlockApp app(argc, argv);
+    app.setQuitOnLastWindowClosed(false);
     QCoreApplication::setApplicationName(QStringLiteral("kscreenlocker_greet"));
     QCoreApplication::setApplicationVersion(QStringLiteral("0.1"));
     QCoreApplication::setOrganizationDomain(QStringLiteral("kde.org"));