From 2e94c635a652a575cb1f25f7dc5bc0ebcdbedcc4 Mon Sep 17 00:00:00 2001 From: Jonathan Davies Date: Mon, 27 Mar 2017 08:58:29 +0000 Subject: [PATCH 10/15] oxenstored: track commit history Since the list of historic activity cannot grow without bound, it is safe to use this to track commits. Reported-by: Juergen Gross Signed-off-by: Jonathan Davies Reviewed-by: Thomas Sanders --- tools/ocaml/xenstored/process.ml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml index 6f4d118..1ed1a8f 100644 --- a/tools/ocaml/xenstored/process.ml +++ b/tools/ocaml/xenstored/process.ml @@ -296,12 +296,7 @@ let write_response_log ~ty ~tid ~con ~response = let record_commit ~con ~tid ~before ~after = let inc r = r := Int64.add 1L !r in let finish_count = inc Transaction.counter; !Transaction.counter in - (* This call would leak memory if historic activity is retained forever - so can only be uncommented if history is guaranteed not to grow - unboundedly. History.push {History.con=con; tid=tid; before=before; after=after; finish_count=finish_count} - *) - () (* Replay a stored transaction against a fresh store, check the responses are all equivalent: if so, commit the transaction. Otherwise send the abort to -- 2.1.4